fix(android): handle aspect ratio for rotated videos #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskalakamil
force-pushed
the
fix/rotated-videos-aspect-ratio
branch
from
ceeb3ae
to
b2e2e53
Compare
freeboub
approved these changes
Jul 12, 2024
KrzysztofMoch
approved these changes
Jul 15, 2024
|
This issue is still happening on my end. We're on 6.5.0 and when we rotate on android the aspect ratio is messed up. |
Can you provide a sample please ? Maybe follow up on a dedicated ticket .. |
|
Figured its from my project. Should be working fine in the library. Thanks @freeboub |
|
I found the problem. The solution is. |
|
@tamdvyounetgroup A PR is welcome, thank you ! |
|
@tamdvyounetgroup I missed to thank you for the patch, it has been integrated in last release ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust aspect ratio handling for rotated videos
Closes #3929
Motivation
In certain cases, the height and width of videos were not adjusting correctly with rotation. This PR addresses this issue by properly handling aspect ratio adjustments based on rotation angles.
Changes
Modified logic to switch height and width when the rotation angle is 90 or 270 degrees.
Test plan